Add pluralName to gItems to allow the proper spelling when multiple items are received at once #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bassoonian
requested changes
Jan 15, 2024
|
here's what needs to be done:
steps
I do not think should block the merging of this PR, this work can absolutely come later I spent about an hour trying to automate this and ran into some problems
so if nobody picks this up by the time I'm back at my desktop with a real keyboard (in a few weeks), I will do it myself then. EDIT: It looks like somebody is willing to do it https://discord.com/channels/419213663107416084/1193434690321911828/1196509391357235231 EDIT: this is done. |
Add remaining plural forms.
Bassoonian
reviewed
Jan 16, 2024
Will deprecate the former in a future feature: rh-hideout#4010
Bassoonian
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reminder: add @GraionDilach to the changelog credits for this PR
Description
Usage
This feature does not require any explicit usage from the player or developer. When the player picks up an item with a special pluralized name, this script will automatically use that name.
New Items
If a new item is added to the game and it should have a special plural form, when adding the item to gItems,
pluralNameshould be defined on the struct for that item.Testing
Clean Branch
You can recreate this branch by pulling the repo.
git remote add psf-expansion https://github.com/PokemonSanFran/pokeemerald-expansion/ ; git pull psf-expansion plural_item_exceptionsManual Tests
To recreate my testing environment, you can either:
Download
wget https://github.com/PokemonSanFran/pokeemerald-expansion/raw/6fbe52373039091c3f01caca0ae64bcabcb59080/pokeemerald.sav ; wget https://raw.githubusercontent.com/PokemonSanFran/pokeemerald-expansion/6fbe52373039091c3f01caca0ae64bcabcb59080/data/scripts/debug.inc -O data/scripts/debug.incManually Apply
Verified Scenarios
Each item in the following lists goes to a timestamped YouTube link with each specific scenario being tested.
Discord Contact Info
I am
pkmnsnfrn. I have already started a discussion thread.